[DRAFT] Notification: Add toString method #1879
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for content-scope-scripts failed.
|
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Thu, 07 Aug 2025 14:33:28 GMT Android
File has changed Apple
File has changed Chrome-mv3File has changed FirefoxFile has changed IntegrationFile has changed WindowsFile has changed |
injected/src/content-feature.js
Outdated
| }, | ||
| }); | ||
| descriptor[k] = wrapToString(wrapper, descriptorProp); | ||
| } | ||
| }); | ||
|
|
||
| return defineProperty(object, propertyName, descriptor); | ||
| return defineProperty(object, String(propertyName), /** @type {any} */ (descriptor)); |
There was a problem hiding this comment.
We could add it here instead.
Suggested change
| return defineProperty(object, String(propertyName), /** @type {any} */ (descriptor)); | |
| const def = defineProperty(object, propertyName, descriptor); | |
| defineProperty(object[propertyName], "toString", somethingThatLookslikeWrapToString); | |
| return def; |
laghee
force-pushed
the
km/notification-add-tostring
branch
from
cac8f10 to
7f7bf30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1201870266890790/task/1210988190527661?focus=true
Description
WIP - testing notification api
Testing Steps
Checklist
Please tick all that apply: