-
Notifications
You must be signed in to change notification settings - Fork 28
ntp: omnibar states #1882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ntp: omnibar states #1882
Conversation
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Fri, 08 Aug 2025 09:54:41 GMT Apple
File has changed Integration
File has changed Windows
File has changed |
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
||
export function factory() { | ||
return ( | ||
<Centered data-entry-point="omnibar"> | ||
<OmnibarCustomized /> | ||
<PersistentTermsProvider> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This state needs to live for the lifespan of the page, not the widget, so we go 1 level higher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of the naming here is a mess - can be addressed after the POC is confirmed working
Asana Task/Github Issue:
Description
Support persistent state for omnibar input.
<tab id>: <input value>
is maintained outside of the lifecycle of the omnibar widget.tabId
- if it does we re-render the omibar widgetsubmit
has the intended effect yetTesting Steps (windows)
tabId
andtabIds
to:omnibar_getConfig
callomnibar_onConfigUpdate
subscription eventThen, every time the tab changes, send
omnibar_onConfigUpdate
back into the page with the updatedtabId
andtabIds
fieldsChecklist
Please tick all that apply: