Skip to content

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Aug 8, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1201141132935289/task/1211139368306662?focus=true

Description

Support persistent state for omnibar input.

  • A mapping of <tab id>: <value> is maintained outside of the lifecycle of the omnibar widget.
  • This solution will allow us to solve the scroll problem soon too 😢

Testing Steps (windows)

  • visit https://deploy-preview-1882--content-scope-scripts.netlify.app/build/pages/new-tab/?omnibar&tabs&tabs.debug=true
  • notice the debug in top left, it will read current: '01'
  • Enter some text in the search box, don't hit enter
  • now in the console, run window._tabs.add('02', ['01', '02']) to simulate a new tab opening on windows
  • notice top left reads current: '02' now, and the input should be empty
  • now switch to Duck.ai and enter some text
  • back in the console, switch back to tab 1 with window._tabs.add('01', ['01', '02'])
  • the original text you entered should be there.

Also, see the integration tests for more info.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Aug 8, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Aug 8, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Aug 8, 2025

[Beta] Generated file diff

Time updated: Thu, 28 Aug 2025 16:39:38 GMT

Apple
    - apple/pages/new-tab/dist/index.js

File has changed

Integration
    - integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.js

File has changed

Copy link

netlify bot commented Aug 8, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 726dc76
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68b08614e26acb0008c29b08
😎 Deploy Preview https://deploy-preview-1882--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@shakyShane shakyShane marked this pull request as ready for review August 8, 2025 09:47
@shakyShane shakyShane requested review from mgurgel and a team as code owners August 8, 2025 09:47
@duckduckgo duckduckgo deleted a comment from cursor bot Aug 8, 2025
@duckduckgo duckduckgo deleted a comment from cursor bot Aug 8, 2025
@shakyShane shakyShane force-pushed the 08-08-ntp_omnibar_states branch from b2bcf87 to 711b68c Compare August 20, 2025 22:24
cursor[bot]

This comment was marked as outdated.

@shakyShane shakyShane force-pushed the 08-08-ntp_omnibar_states branch from 711b68c to 754365a Compare August 21, 2025 10:36
cursor[bot]

This comment was marked as outdated.

@shakyShane shakyShane force-pushed the 08-08-ntp_omnibar_states branch 2 times, most recently from 43cd2af to 49ac3ca Compare August 25, 2025 20:10
cursor[bot]

This comment was marked as outdated.

@duckduckgo duckduckgo deleted a comment from cursor bot Aug 26, 2025
cursor[bot]

This comment was marked as outdated.

@shakyShane shakyShane mentioned this pull request Aug 26, 2025
8 tasks
cursor[bot]

This comment was marked as outdated.

@shakyShane shakyShane force-pushed the 08-08-ntp_omnibar_states branch from b8e31d1 to bc3121e Compare August 26, 2025 15:06
cursor[bot]

This comment was marked as outdated.

@duckduckgo duckduckgo deleted a comment from cursor bot Aug 28, 2025
@duckduckgo duckduckgo deleted a comment from cursor bot Aug 28, 2025
@duckduckgo duckduckgo deleted a comment from cursor bot Aug 28, 2025
@shakyShane shakyShane force-pushed the 08-08-ntp_omnibar_states branch from 198a90a to 726dc76 Compare August 28, 2025 16:38
@shakyShane shakyShane enabled auto-merge August 28, 2025 16:39
@shakyShane shakyShane added this pull request to the merge queue Aug 28, 2025
github-merge-queue bot pushed a commit that referenced this pull request Aug 28, 2025
* ntp: support persistent values

* docs

* docs

* some more docs

* feedback

* only use saved mode if enableAi is on

* only use saved mode if enableAi is on

* better handling of global

* another global fix
@shakyShane shakyShane removed this pull request from the merge queue due to a manual request Aug 28, 2025
@shakyShane shakyShane added this pull request to the merge queue Aug 28, 2025
Merged via the queue into main with commit 7ba712a Aug 28, 2025
17 checks passed
@shakyShane shakyShane deleted the 08-08-ntp_omnibar_states branch August 28, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants