ntp: omnibar states #1882

shakyShane · 2025-08-08T09:44:29Z

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1201141132935289/task/1211139368306662?focus=true

Description

Support persistent state for omnibar input.

A mapping of <tab id>: <value> is maintained outside of the lifecycle of the omnibar widget.
This solution will allow us to solve the scroll problem soon too 😢

Testing Steps (windows)

visit https://deploy-preview-1882--content-scope-scripts.netlify.app/build/pages/new-tab/?omnibar&tabs&tabs.debug=true
notice the debug in top left, it will read current: '01'
Enter some text in the search box, don't hit enter
now in the console, run window._tabs.add('02', ['01', '02']) to simulate a new tab opening on windows
notice top left reads current: '02' now, and the input should be empty
now switch to Duck.ai and enter some text
back in the console, switch back to tab 1 with window._tabs.add('01', ['01', '02'])
the original text you entered should be there.

Also, see the integration tests for more info.

Checklist

Please tick all that apply:

I have tested this change locally
I have tested this change locally in all supported browsers
This change will be visible to users
I have added automated tests that cover this change
I have ensured the change is gated by config
This change was covered by a ship review
This change was covered by a tech design
Any dependent config has been merged

shakyShane · 2025-08-08T09:44:48Z

ntp: support scroll restoration #1921
ntp: omnibar states #1882 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-08-08T09:45:02Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1882
Commit Hash: ab1dcafcab46f1e641a70505fdb91903ff99021f
Last Updated: August 28, 2025 at 4:39:19 PM UTC
Install Command: npm i github:duckduckgo/content-scope-scripts#ab1dcafcab46f1e641a70505fdb91903ff99021f

Please use the above install command to update to the latest version.

github-actions · 2025-08-08T09:45:39Z

[Beta] Generated file diff

Time updated: Thu, 28 Aug 2025 16:39:38 GMT

Apple

    - apple/pages/new-tab/dist/index.js

File has changed

Integration

    - integration/pages/new-tab/dist/index.js

File has changed

Windows

    - windows/pages/new-tab/dist/index.js

File has changed

netlify · 2025-08-08T09:46:50Z

✅ Deploy Preview for content-scope-scripts ready!

Name	Link
🔨 Latest commit	`726dc76`
🔍 Latest deploy log	https://app.netlify.com/projects/content-scope-scripts/deploys/68b08614e26acb0008c29b08
😎 Deploy Preview	https://deploy-preview-1882--content-scope-scripts.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

special-pages/pages/new-tab/app/entry-points/omnibar.js

special-pages/pages/new-tab/app/omnibar/components/PersistentTermsProvider.js

special-pages/pages/new-tab/app/customizer/components/CustomizerMenu.js

* ntp: support persistent values * docs * docs * some more docs * feedback * only use saved mode if enableAi is on * only use saved mode if enableAi is on * better handling of global * another global fix

shakyShane marked this pull request as ready for review August 8, 2025 09:47

shakyShane requested review from mgurgel and a team as code owners August 8, 2025 09:47

duckduckgo deleted a comment from cursor bot Aug 8, 2025

shakyShane commented Aug 8, 2025

View reviewed changes

special-pages/pages/new-tab/app/entry-points/omnibar.js Outdated Show resolved Hide resolved

duckduckgo deleted a comment from cursor bot Aug 8, 2025

shakyShane commented Aug 8, 2025

View reviewed changes

special-pages/pages/new-tab/app/omnibar/components/PersistentTermsProvider.js Outdated Show resolved Hide resolved

shakyShane force-pushed the 08-08-ntp_omnibar_states branch from b2bcf87 to 711b68c Compare August 20, 2025 22:24