Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 15, 2025

Bumps @atlaskit/pragmatic-drag-and-drop from 1.7.6 to 1.7.7.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [@atlaskit/pragmatic-drag-and-drop](https://github.com/atlassian/pragmatic-drag-and-drop) from 1.7.6 to 1.7.7.
- [Commits](https://github.com/atlassian/pragmatic-drag-and-drop/commits)

---
updated-dependencies:
- dependency-name: "@atlaskit/pragmatic-drag-and-drop"
  dependency-version: 1.7.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Update one or more dependencies version patch Increment the patch version when merged labels Sep 15, 2025
@dependabot dependabot bot requested review from a team, mgurgel and shakyShane as code owners September 15, 2025 10:42
@dependabot dependabot bot added dependencies Update one or more dependencies version patch Increment the patch version when merged labels Sep 15, 2025
@github-actions
Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@netlify
Copy link

netlify bot commented Sep 15, 2025

Deploy Preview for content-scope-scripts canceled.

Name Link
🔨 Latest commit 5530789
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68c7ed80d4a85a000846b5e8

@jonathanKingston
Copy link
Contributor

@cursoragent can you review against our current code and outline potential impacts based on the changelogs of the update?

@cursor
Copy link

cursor bot commented Dec 8, 2025

Review: @atlaskit/pragmatic-drag-and-drop 1.7.6 → 1.7.7

Changelog Analysis

1.7.7 (this update):

"Internal changes to how borders are applied"

This is a patch release with purely internal styling changes—no public API modifications.

Your Code Usage (PragmaticDND.js)

Your implementation uses these imports from the core package:

Import Usage
draggable, dropTargetForElements, monitorForElements Element drag/drop setup
dropTargetForExternal, monitorForExternal External drop handling
combine Cleanup function composition
getHTML External payload parsing
setCustomNativeDragPreview Custom drag preview
centerUnderPointer Preview positioning

Impact Assessment

Low risk. The internal border changes relate to how pointerOutsideOfPreview utility handles preview positioning—your code doesn't use this utility. You use centerUnderPointer instead (line 184).

Key Observations

  1. No API changes — All imports and function signatures remain stable
  2. No behavioral changes for your code paths — The border changes affect pointerOutsideOfPreview internals
  3. TypeScript fixes in 1.7.6 were for Atlassian's internal "adminhub" consumption, not public types
  4. Cleanup function idempotency (1.7.2) — Your useEffect cleanup via combine() already handles single-call semantics correctly

Recommendation

Safe to merge. This is a low-impact internal patch. If you want extra assurance:

# Quick manual test of the new-tab favorites drag-and-drop
npm run build.special-pages && npm run test:playwright -- --grep favorites

No code changes required in your implementation.


Open in Cursor Open in Web

Learn more about Cursor Agents

@cursor
Copy link

cursor bot commented Dec 8, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@jonathanKingston jonathanKingston added this pull request to the merge queue Dec 8, 2025
Merged via the queue into main with commit 1e9eaca Dec 8, 2025
21 checks passed
@jonathanKingston jonathanKingston deleted the dependabot/npm_and_yarn/main/atlaskit/pragmatic-drag-and-drop-1.7.7 branch December 8, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Update one or more dependencies version patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants