-
Notifications
You must be signed in to change notification settings - Fork 31
build(deps): bump @atlaskit/pragmatic-drag-and-drop from 1.7.6 to 1.7.7 #1968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump @atlaskit/pragmatic-drag-and-drop from 1.7.6 to 1.7.7 #1968
Conversation
Bumps [@atlaskit/pragmatic-drag-and-drop](https://github.com/atlassian/pragmatic-drag-and-drop) from 1.7.6 to 1.7.7. - [Commits](https://github.com/atlassian/pragmatic-drag-and-drop/commits) --- updated-dependencies: - dependency-name: "@atlaskit/pragmatic-drag-and-drop" dependency-version: 1.7.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
✅ Deploy Preview for content-scope-scripts canceled.
|
|
@cursoragent can you review against our current code and outline potential impacts based on the changelogs of the update? |
Review:
|
| Import | Usage |
|---|---|
draggable, dropTargetForElements, monitorForElements |
Element drag/drop setup |
dropTargetForExternal, monitorForExternal |
External drop handling |
combine |
Cleanup function composition |
getHTML |
External payload parsing |
setCustomNativeDragPreview |
Custom drag preview |
centerUnderPointer |
Preview positioning |
Impact Assessment
Low risk. The internal border changes relate to how pointerOutsideOfPreview utility handles preview positioning—your code doesn't use this utility. You use centerUnderPointer instead (line 184).
Key Observations
- No API changes — All imports and function signatures remain stable
- No behavioral changes for your code paths — The border changes affect
pointerOutsideOfPreviewinternals - TypeScript fixes in 1.7.6 were for Atlassian's internal "adminhub" consumption, not public types
- Cleanup function idempotency (1.7.2) — Your
useEffectcleanup viacombine()already handles single-call semantics correctly
Recommendation
Safe to merge. This is a low-impact internal patch. If you want extra assurance:
# Quick manual test of the new-tab favorites drag-and-drop
npm run build.special-pages && npm run test:playwright -- --grep favoritesNo code changes required in your implementation.
Learn more about Cursor Agents
|
Cursor Agent can help with this pull request. Just |
Bumps @atlaskit/pragmatic-drag-and-drop from 1.7.6 to 1.7.7.
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)