Skip to content

Conversation

@jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Sep 26, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1206670747178362/task/1211476403120852?focus=true

Description

Origin trials on some sites harm our messages, here it's safe to fallback to the platform implementation. This will trigger prompts due to another WebView issue on Windows but only for first time users so it's an acceptable tradeoff for a potentially bricked site.

Testing Steps

  • Remove our override to autotrader.com
  • Go to the console and type: await navigator.mediaDevices.enumerateDevices()

Notice that it will now timeout:
image

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@netlify
Copy link

netlify bot commented Sep 26, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 05c288d
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68d65d700aa2dc0008db64ee
😎 Deploy Preview https://deploy-preview-1982--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Sep 26, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Sep 26, 2025

[Beta] Generated file diff

Time updated: Fri, 26 Sep 2025 09:32:25 GMT

Android
    - android/adsjsContentScope.js
  • android/contentScope.js

File has changed

Apple
    - apple/contentScope.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

@jonathanKingston jonathanKingston marked this pull request as ready for review September 26, 2025 09:22
@jonathanKingston jonathanKingston requested a review from a team as a code owner September 26, 2025 09:22
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, and I agree it might warrant being in the messaging layer. my original implementation allows passing an abort signal as part of an options object on .request() calls, so we should probably go down that route.

approving for now, thanks

@jonathanKingston
Copy link
Contributor Author

looks good, and I agree it might warrant being in the messaging layer. my original implementation allows passing an abort signal as part of an options object on .request() calls, so we should probably go down that route.

approving for now, thanks

As we discussed, we quickly tried this. Some of the wiring is there only for Windows but it's unclear if it's working even if we wire in the opts to the transport.
The immediate concern is fixing this and there were concerns with this design anyway.

@jonathanKingston jonathanKingston added this pull request to the merge queue Sep 26, 2025
Merged via the queue into main with commit 5f35ef7 Sep 26, 2025
22 checks passed
@jonathanKingston jonathanKingston deleted the jkt/enumerateDevicesTimeout branch September 26, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants