-
Notifications
You must be signed in to change notification settings - Fork 30
Add timeout to enumerateDevices call #1982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Fri, 26 Sep 2025 09:32:25 GMT Android
File has changed AppleFile has changed IntegrationFile has changed WindowsFile has changed |
d61fa31 to
05c288d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, and I agree it might warrant being in the messaging layer. my original implementation allows passing an abort signal as part of an options object on .request() calls, so we should probably go down that route.
approving for now, thanks
As we discussed, we quickly tried this. Some of the wiring is there only for Windows but it's unclear if it's working even if we wire in the opts to the transport. |
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1206670747178362/task/1211476403120852?focus=true
Description
Origin trials on some sites harm our messages, here it's safe to fallback to the platform implementation. This will trigger prompts due to another WebView issue on Windows but only for first time users so it's an acceptable tradeoff for a potentially bricked site.
Testing Steps
Notice that it will now timeout:

Checklist
Please tick all that apply: