-
Notifications
You must be signed in to change notification settings - Fork 29
Hidden context removal and recheck #1997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Wed, 08 Oct 2025 14:33:31 GMT Apple
File has changed Integration
File has changed Windows
File has changed |
} catch (e) { | ||
return false; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Styling Checks Fail on Detached Nodes
The checkNodeIsVisible()
function uses getComputedStyle()
on cloned, disconnected DOM nodes. Since getComputedStyle()
returns default values for disconnected elements, the visibility checks are unreliable, potentially filtering out visible content or including hidden content.
Pull request was converted to draft
Going to split apart the PR into #1970 again. Then recheck the hidden part over coming back here. |
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1199237043598868/task/1211551437155181?focus=true
Description
Testing Steps
Checklist
Please tick all that apply:
Note
Filters out hidden elements during content collection and schedules a delayed recheck after navigation events with cache invalidation.
checkNodeIsVisible
indomToMarkdown
.#delayedRecheckTimer
) triggered onload
,hashchange
, andurlChanged
.scheduleDelayedRecheck()
invalidates cache, recollects content, and sends response after a configurable delay (navigationRecheckDelayMs
, default 1500ms).clearTimers()
to cancel pending timers.Written by Cursor Bugbot for commit 7191585. This will update automatically on new commits. Configure here.