Skip to content

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Oct 9, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1211551437155183?focus=true

Description

Adds remote settings for everything that is a constant in the page collection feature.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Note

Adds feature settings to configure selectors and thresholds for content, headings, links, and images, including a separate list for inert elements.

  • Page context (injected/src/features/page-context.js)
    • Configurable main content extraction:
      • mainContentSelector (default: main, article, .content, .main, #content, #main)
      • mainContentLength (default: 100)
      • excludedInertElements (default: script, style, link, meta, noscript, svg, canvas), merged with excludeSelectors
    • Configurable selectors:
      • headingSelector (default: h1, h2, h3, h4, h5, h6)
      • linkSelector (default: a[href])
      • imgSelector (default: img)

Written by Cursor Bugbot for commit ac7c1b8. This will update automatically on new commits. Configure here.

@jonathanKingston jonathanKingston marked this pull request as ready for review October 9, 2025 10:30
@jonathanKingston jonathanKingston requested a review from a team as a code owner October 9, 2025 10:30
Copy link

netlify bot commented Oct 9, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit ac7c1b8
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68e78eabd0717000084c18f5
😎 Deploy Preview https://deploy-preview-1998--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Oct 9, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Oct 9, 2025

[Beta] Generated file diff

Time updated: Thu, 09 Oct 2025 10:30:57 GMT

Apple
    - apple/contentScope.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

@jonathanKingston jonathanKingston added this pull request to the merge queue Oct 9, 2025
Merged via the queue into main with commit e62b752 Oct 9, 2025
25 checks passed
@jonathanKingston jonathanKingston deleted the jkt/addConfigForAllPageContextConstants branch October 9, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants