jingram/subscription win back banner: Adds Subscription Win-Back Banner #2014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Fri, 17 Oct 2025 17:04:28 GMT Apple
File has changed Integration
File has changed Windows
File has changed New Files
❌ File only exists in new changeset |
jsoningram
force-pushed
the
jingram/subscription-win-back-banner
branch
3 times, most recently
from
9a8d0a7 to
5ac27c9
Compare
Remove freemium dir from test-unit script
Include supporting svg
jsoningram
force-pushed
the
jingram/subscription-win-back-banner
branch
from
5ac27c9 to
2016065
Compare
jsoningram
requested review from
a team,
mgurgel and
shakyShane
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| test('renders a title, descriptionText an action button, and dismiss button', async ({ page }, workerInfo) => { | ||
| const ntp = NewtabPage.create(page, workerInfo); | ||
| await ntp.reducedMotion(); | ||
| await ntp.openPage({ winback: 'true' }); |
There was a problem hiding this comment.
Bug: Test Fails Due to Mismatched Parameter Handling
The integration test passes winback='true' in the URL, but the mock transport expects this parameter to be a key in subscriptionWinBackBannerDataExamples. Since subscriptionWinBackBannerDataExamples only contains 'winback_last_day', the banner data isn't loaded, which causes the integration test to fail.
Additional Locations (2)
vkraucunas
reviewed
Oct 17, 2025
| @@ -0,0 +1,41 @@ | |||
| /** | |||
| * Using CSS Modules 'composes' to import styles from FreemiumPIRBanner. | |||
There was a problem hiding this comment.
very cool! today i learned. 🙌
vkraucunas
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1211050482669423/task/1211622723586657?focus=true
Figma: https://www.figma.com/design/tnk4CZcOZ5feYM20N57Tgs/Subscription-Win-Back-Offer?node-id=211-27666&m=dev
Description
Add a new Subscription Win-back Banner component (SubscriptionWinBackBanner) to the New Tab Page, allowing the native application to display resubscribe messages to users with lapsed subscriptions. This new component used the Freemium PIR banner component as a base and functions the same way. Notable differences are:
I’ve also moved the
convertMarkdownToHTMLForStrongTagsutility function to the shared utils directory since both this new component and the Freemium PIR banner both make use of it. I’ve updated the unit tests and references to the function to support this change.Additionally I’ve updated
stylelintrc.jsonto allow for CSS module composition and avoid duplication of the entire Freemium PIR banner styles and still be able to easily support future changes.Testing Steps
Checklist
Please tick all that apply: