Skip to content

Conversation

@jsoningram
Copy link
Contributor

@jsoningram jsoningram commented Dec 5, 2025

Asana Task/Github Issue: Maxing out tracking attempts blocked metric at 9999
Figma

Description

Increases the maximum display count from 9,999 to 9,999,999 and adds locale-aware number formatting.

Max (both) Max cookie Max (both, locale=ru
image image image

Testing Steps

Check the following scenarios. You can adjust the query parameters to observe different states.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Note

Raises max displayed counts to 9,999,999, adds locale-aware number formatting, updates mocks/tests, and tweaks layout spacing.

  • Protections/Animation:
    • Increase AnimationConstants.MAX_DISPLAY_COUNT to 9,999,999 and apply cap in animateCount.
    • Update unit tests to reference AnimationConstants and expected capped behavior.
  • UI:
    • ProtectionsHeading.js: format counts via useLocale + getLocalizedNumberFormatter (with useMemo); apply formatting to trackers and cookie pop-ups; add styles.cookiePopUpsCounter with cn.
    • PrivacyStats.module.css: reduce counterContainer gap; set fixed counter width/padding with content-box; add .cookiePopUpsCounter; ensure title spans wrap (word-wrap/overflow-wrap).
  • Mocks:
    • protections.mock-transport.js: use AnimationConstants for max values; support cpm=true (cookie pop-ups max) and cpm=max (both totals max).

Written by Cursor Bugbot for commit e1aa983. This will update automatically on new commits. Configure here.

@netlify
Copy link

netlify bot commented Dec 5, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit e1aa983
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/69335b2833adde0008172bb2
😎 Deploy Preview https://deploy-preview-2083--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

[Beta] Generated file diff

Time updated: Fri, 05 Dec 2025 22:48:16 GMT

Apple
    - apple/pages/new-tab/dist/index.css
  • apple/pages/new-tab/dist/index.js

File has changed

Integration
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js

File has changed

@jsoningram jsoningram changed the title Jingram/cpm stats count capacity increase jingram/cpm-stats-count-capacity-increase: Increase tracker and cookie pop-up counter capacity Dec 5, 2025
@jsoningram jsoningram marked this pull request as ready for review December 5, 2025 22:47
@jsoningram jsoningram requested review from a team, mgurgel and shakyShane as code owners December 5, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant