Skip to content

Conversation

@jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Dec 8, 2025

Asana Task/Github Issue: Instead of #2050

Description

Replace external wait-on package with inline waitForServer function. This reduces transitive dependencies (including axios) while providing equivalent functionality for the fake-extension dev script.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Note

Replaces the wait-on dependency by adding a local waitForServer poller in injected/scripts/run-fake-extension.js and removes wait-on (and transitives) from dependencies; minor cleanup in mock transport.

  • Dev tooling:
    • Server wait logic: Add waitForServer(url) in injected/scripts/run-fake-extension.js and use it instead of wait-on to wait for http://localhost:3220/index.html.
    • Dependency cleanup: Remove wait-on from package.json and prune related entries in package-lock.json.
  • Misc:
    • Minor lint/comment cleanup in special-pages/pages/new-tab/app/mock-transport.js.

Written by Cursor Bugbot for commit df5215d. This will update automatically on new commits. Configure here.

Replace external wait-on package with inline waitForServer function.
This reduces transitive dependencies (including axios) while providing
equivalent functionality for the fake-extension dev script.
@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit df5215d
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/6939260422087ecca77cbe6e
😎 Deploy Preview https://deploy-preview-2092--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

[Beta] Generated file diff

Time updated: Tue, 09 Dec 2025 16:38:13 GMT

@jonathanKingston jonathanKingston marked this pull request as ready for review December 8, 2025 10:57
@jonathanKingston jonathanKingston requested a review from a team as a code owner December 8, 2025 10:57
@cursor
Copy link

cursor bot commented Dec 8, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@jonathanKingston jonathanKingston added this pull request to the merge queue Dec 10, 2025
Merged via the queue into main with commit 2b9d7a4 Dec 10, 2025
20 checks passed
@jonathanKingston jonathanKingston deleted the remove-wait-on-dependency branch December 10, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants