Fix compatibility with scipy 0.14#34
Merged
duetosymmetry merged 1 commit intoduetosymmetry:masterfrom Apr 4, 2025
Merged
Conversation
Contributor
Author
|
Note that this does not fix an actual failure that was hidden by the incompatibility, please see https://github.com/duncanmmacleod/qnm/actions/runs/14262355782/job/39976574931. |
Owner
|
Thanks, I will look at the actual failure when I get a chance... The automated building of the cache is sensitive to choices of step sizes, so I probably have to fiddle with those choices to make it more robust. |
duetosymmetry
force-pushed
the
scipy-0.14
branch
from
b5bce66 to
9f77ff0
Compare
Owner
|
Hope you don't mind that I rebased on master and force pushed, so that the tests would now run here in the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #33 by updating the usage of
scipy.optimize.NoConvergence.