Skip to content

fix: update broken fare condition types #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorp1 merged 1 commit into from
Aug 12, 2025
Merged

fix: update broken fare condition types #1079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/booking/AirlineInitiatedChanges/mockAirlineInitiatedChanges.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export const mockAirlineInitiatedChange: AirlineInitiatedChange = {
penalty_amount: '100.00',
allowed: true,
},
refund_before_departure: null,
},
destination_type: 'airport',
origin_type: 'airport',
Expand Down Expand Up @@ -147,7 +146,6 @@ export const mockAirlineInitiatedChange: AirlineInitiatedChange = {
penalty_amount: '100.00',
allowed: true,
},
refund_before_departure: null,
},
destination_type: 'airport',
origin_type: 'airport',
Expand Down
6 changes: 3 additions & 3 deletions src/booking/Orders/OrdersTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@ import {
CabinClass,
DuffelPassengerGender,
DuffelPassengerTitle,
PassengerType,
FlightsConditions,
LoyaltyProgrammeAccount,
OfferAvailableServiceBaggage,
OfferAvailableServiceBaggageMetadata,
OrderCancellation,
PassengerIdentityDocumentType,
PassengerType,
PaymentType,
Place,
PlaceType,
OrderCancellation,
} from '../../types'

/**
Expand Down Expand Up @@ -347,7 +347,7 @@ export interface OrderSlice {
* The conditions associated with this slice, describing the kinds of modifications you can make and any penalties that will apply to those modifications.
* This condition is applied only to this slice and to all the passengers associated with this order - for information at the order level (e.g. "what happens if I want to change all the slices?") refer to the `conditions` at the top level. If a particular kind of modification is allowed, you may not always be able to take action through the Duffel API. In some cases, you may need to contact the Duffel support team or the airline directly.
*/
conditions: FlightsConditions
conditions: Omit<FlightsConditions, 'refund_before_departure'>
/**
* The city or airport where this slice ends
*/
Expand Down
3 changes: 0 additions & 3 deletions src/booking/Orders/mockOrders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@ export const mockOrder: Order = {
penalty_amount: '100.00',
allowed: true,
},
refund_before_departure: null,
},
},
],
Expand Down Expand Up @@ -423,7 +422,6 @@ export const mockOnHoldOrders: Order[] = [
},
conditions: {
change_before_departure: null,
refund_before_departure: null,
},
},
],
Expand Down Expand Up @@ -604,7 +602,6 @@ export const mockOnHoldOrders: Order[] = [
},
conditions: {
change_before_departure: null,
refund_before_departure: null,
},
},
],
Expand Down
4 changes: 2 additions & 2 deletions src/types/shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,15 @@ export type FlightsConditionAllowed = {
*
* @example "GBP"
*/
penalty_currency: string
penalty_currency: string | null
/**
* If the modification is `allowed` then this is the amount payable to apply the modification to all passengers.
* If there is no penalty, the value will be zero. If the modification isn't `allowed` or the penalty is not known then this field will be `null`.
* If this is `null` then the `penalty_currency` will also be null.
*
* @example "100.00"
*/
penalty_amount: string
penalty_amount: string | null
/**
* Whether this kind of modification is allowed post-booking
*
Expand Down