Skip to content

feat: expand types to have estimated commission #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jekku merged 1 commit into from
Oct 15, 2025
Merged

feat: expand types to have estimated commission #1091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/Stays/StaysTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,16 @@ export interface StaysRate {
*/
loyalty_programme_required: boolean

/**
* The estimated commission amount for this rate.
*/
estimated_commission_amount: string | null

/**
* The currency of the estimated_commission_amount.
*/
estimated_commission_currency: string | null

/**
* The source of the rate.
* Useful in scenarios where a rate requires explicitly showing the source.
Expand Down Expand Up @@ -654,6 +664,16 @@ export interface StaysBooking {
* Deprecated: Instructions to access the accommodation in the booking
*/
key_collection: StaysBookingKeyCollection | null

/**
* The estimated commission amount for this rate.
*/
estimated_commission_amount: string | null

/**
* The currency of the estimated_commission_amount.
*/
estimated_commission_currency: string | null
}

// Age is not required for adult, but required for child
Expand Down
6 changes: 6 additions & 0 deletions src/Stays/mocks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ export const MOCK_ACCOMMODATION: StaysAccommodation = {
supported_loyalty_programme: null,
loyalty_programme_required: false,
source: 'duffel_hotel_group',
estimated_commission_amount: '10.00',
estimated_commission_currency: 'GBP',
},
{
total_currency: 'GBP',
Expand Down Expand Up @@ -94,6 +96,8 @@ export const MOCK_ACCOMMODATION: StaysAccommodation = {
supported_loyalty_programme: 'duffel_hotel_group_rewards',
loyalty_programme_required: true,
source: 'duffel_hotel_group',
estimated_commission_amount: '10.00',
estimated_commission_currency: 'GBP',
},
],
photos: [
Expand Down Expand Up @@ -230,6 +234,8 @@ export const MOCK_BOOKING: StaysBooking = {
metadata: {
checkout_reference: 'usr_0000AePJGl5G9ZYfmNllrs',
},
estimated_commission_amount: '10.00',
estimated_commission_currency: 'GBP',
}

export const MOCK_CREATE_BOOKING_PAYLOAD: StaysBookingPayload = {
Expand Down