[STAY-2408] feat: add deposit type to stays payment type #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorp1
reviewed
Jan 29, 2025
igorp1
previously approved these changes
Jan 29, 2025
Contributor
igorp1
left a comment
igorp1
left a comment
There was a problem hiding this comment.
Besides the version change, LGTM!
igorp1
reviewed
Jan 29, 2025
SamHutchings
force-pushed
the
add-deposit-rate
branch
2 times, most recently
from
d175296 to
259e603
Compare
SamHutchings
force-pushed
the
add-deposit-rate
branch
from
259e603 to
3e5e4ab
Compare
Contributor
Author
jekku
approved these changes
Jan 29, 2025
Contributor
jekku
left a comment
jekku
left a comment
There was a problem hiding this comment.
This enum re-ordering gives me a massive sense of relief.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We are starting to offer deposit rates via the Stays API. We are not yet finished with our implementation, waiting on details from Travelport around how we can show this data in a structured way. However, to unblock some customers and gather some data on what these rates look like, we are going to allow booking these rates.
We aren't adding support for booking these via the dashboard yet, but once booked both Duffel and other dashboard users will need to view the booking details, so we need to add this type to add a new price breakdown component for deposit type rates.
Implementation
depositto the payment types type.