Skip to content

Check for VSB errors earlier in function #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duffn merged 1 commit into from
Oct 22, 2025
Merged

Check for VSB errors earlier in function #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/vmod_querymodifier.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,11 @@ static char *rebuild_query_string(VRT_CTX, const char *uri_base,
}

VSB_cat(vsb, uri_base);
if (VSB_error(vsb)) {
VRT_fail(ctx, "VSB overflow while appending base URI");
VSB_destroy(&vsb);
return NULL;
}

for (size_t i = 0; i < param_count; i++) {
query_param_t *current = &params[i];
Expand All @@ -181,6 +186,13 @@ static char *rebuild_query_string(VRT_CTX, const char *uri_base,
// Parameter with no value
VSB_printf(vsb, "%c%s", sep, current->name);
}

if (VSB_error(vsb)) {
VRT_fail(ctx, "VSB overflow while building query string");
VSB_destroy(&vsb);
return NULL;
}

sep = '&';
}
}
Expand Down