Add header images and background colors. Fixes #52#88
Open
atodorov wants to merge 1 commit intoduilio:masterfrom
Open
Add header images and background colors. Fixes #52#88atodorov wants to merge 1 commit intoduilio:masterfrom
atodorov wants to merge 1 commit intoduilio:masterfrom
Conversation
| Header image or background color | ||
| -------------------------------- | ||
|
|
||
| - ``header_cover`` - header background image. Configure as article metadata |
Owner
There was a problem hiding this comment.
I see you have listed the options in the same order of priority given in the code. Can you write just a line before to make it explicit in the doc?
Also, wouldn't it be better to actually give more priority to the article's properties instead of cover -> color? Something like:
- article's
header_coverproperty - article's
header_colorproperty - global
HEADER_COVER - global
HEADER_COLOR
atodorov
force-pushed
the
issue52_header_image
branch
from
7f8fcd9 to
bdbee0a
Compare
Contributor
Author
|
ping, any updates here? This can still be merged directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See my comment at
#52 (comment)
for implementation specific details