Skip to content

Ensure minimum token lifetime #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Ensure minimum token lifetime #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions server/auth/local/local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import secrets
from base64 import b32encode
from datetime import datetime, timedelta
from datetime import datetime, timedelta, timezone

from fastapi import Depends, HTTPException, Request
from fastapi.security import OAuth2PasswordBearer
Expand Down Expand Up @@ -29,6 +29,8 @@ def __init__(self) -> None:
self.session_expiry_days = get_env(
"FLATNOTES_SESSION_EXPIRY_DAYS", default=30, cast_int=True
)
if self.session_expiry_days < 0:
self.session_expiry_days = 0

# TOTP
self.is_totp_enabled = False
Expand Down Expand Up @@ -101,8 +103,9 @@ def _validate_token(self, token: str) -> bool:

def _create_access_token(self, data: dict):
to_encode = data.copy()
expiry_datetime = datetime.utcnow() + timedelta(
days=self.session_expiry_days
expiry_datetime = datetime.now(timezone.utc) + timedelta(
days=self.session_expiry_days,
seconds=30
)
to_encode.update({"exp": expiry_datetime})
encoded_jwt = jwt.encode(
Expand Down