Updating is_binary function #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Providing more reliable solution to check if a file is a binary or not Still providing the legacy check if mbstring is not installed
Just checking the first chunk to limit memory usage
Owner
|
Thanks, i will test and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue #70
The current function check if "text" or "x-empty" is in the mimetype to determine if it's a binary or not.
We have some files flagged as
application/javascriptthat are considered as binary even if they are not.This PR correct it by relying on file encoding.
The flaw is that it depends on mbstring (might not be installed everywhere) so the legacy function is still here for fallback.