Skip to content

Last fixes #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ToniGrbic merged 3 commits into from
Oct 5, 2025
Merged

Last fixes #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2deb772
revert admin email sending as raw text instead of html
ToniGrbic Oct 5, 2025
6edd3eb
allow member to update test
ToniGrbic Oct 5, 2025
be8439a
comment out unused variable for now
ToniGrbic Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions apps/api/src/email/email.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,25 +35,26 @@ export class EmailService {
},
});

const createdEmails = await Promise.all(
/* const createdEmails = */
await Promise.all(
interns.map((i) => this.createEmailForIntern(i, subject, text)),
);

const template = nunjucks.compile(text);

return Promise.allSettled(
interns.map((intern) => {
const emailId = createdEmails.find(
/*const emailId = createdEmails.find(
(email) => email.internId === intern.id,
).id;

const trackImage = `<img src="https://internship.dump.hr/api/email/logo?emailId=${emailId}" width="1" height="1" style="display:none" />`;
const trackImage = `<img src="https://internship.dump.hr/api/email/logo?emailId=${emailId}" width="1" height="1" style="display:none" />`; */

return this.postmark.sendEmail({
From: 'info@dump.hr',
To: intern.email,
Subject: subject,
HtmlBody: `${template.render({ intern })} ${trackImage}`,
/* HtmlBody: `${template.render({ intern })} ${trackImage}`, */
TextBody: `${template.render({ intern })}`,
MessageStream: 'outbound',
});
}),
Expand Down
2 changes: 1 addition & 1 deletion apps/api/src/test-slot/test-slot.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export class TestSlotController {
}

@Put(':id')
@UseGuards(AdminGuard)
@UseGuards(MemberGuard)
async updateTestSlot(
@Param('id') testSlotId: string,
@Body() { data }: UpdateTestSlotRequest,
Expand Down