Skip to content

Ninom5/delete events on interview slot cancel#289

Merged
ninom5 merged 3 commits intomainfrom
ninom5/delete-events-on-interview-slot-cancel
Oct 12, 2025
Merged

Ninom5/delete events on interview slot cancel#289
ninom5 merged 3 commits intomainfrom
ninom5/delete-events-on-interview-slot-cancel

Conversation

@ninom5
Copy link
Member

@ninom5 ninom5 commented Oct 10, 2025

No description provided.

@ninom5 ninom5 marked this pull request as draft October 10, 2025 14:29
@ninom5 ninom5 requested a review from Copilot October 10, 2025 19:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements functionality to delete Microsoft Outlook events when interview slots are cancelled. The changes ensure that when interns are removed from interview slots, the corresponding calendar events are also deleted from the Outlook calendar.

  • Added event deletion capability to Microsoft Graph service
  • Integrated event deletion into the intern cancellation workflow
  • Updated interview slot time filtering from 4 to 8 hours

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
apps/api/src/interview-slot/interview-slot.service.ts Increased minimum advance time for interview slots from 4 to 8 hours
apps/api/src/interview-slot/graph.service.ts Added methods to retrieve all events and delete specific events by intern name
apps/api/src/intern/intern.service.ts Integrated event deletion into intern cancellation process
apps/api/src/intern/intern.module.ts Added MicrosoftGraphService as a provider dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ninom5 ninom5 requested a review from ToniGrbic October 10, 2025 19:15
@ninom5 ninom5 self-assigned this Oct 10, 2025
@ninom5 ninom5 marked this pull request as ready for review October 10, 2025 19:15
@dump-hr dump-hr deleted a comment from Copilot AI Oct 10, 2025
@dump-hr dump-hr deleted a comment from Copilot AI Oct 10, 2025
@ninom5 ninom5 requested review from lucijs and lukazuljevic October 10, 2025 21:17
@ninom5
Copy link
Member Author

ninom5 commented Oct 10, 2025

btw ako imaju 2 internas istin imenon i prezimeneon i ako ides cancelat intervju za obojic u isto vrime, cancelat ce se samo jedan, al realno nece se to desit pa nije bitno. mogu nekad naknadno popravit neka sad stoji ovako

@ninom5 ninom5 requested a review from ivonaaaa October 12, 2025 08:03
Copy link
Member

@ToniGrbic ToniGrbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

izgleda sve ok, nisam testira. Je li onda izbriše i event za rezervaciju DUMP ureda? Jer to je malo drugačiji subject, ima nadodano na početku još "DUMP Event scheduler".

@ninom5
Copy link
Member Author

ninom5 commented Oct 12, 2025

izgleda sve ok, nisam testira. Je li onda izbriše i event za rezervaciju DUMP ureda? Jer to je malo drugačiji subject, ima nadodano na početku još "DUMP Event scheduler".

pa meni bi doslo na mail da je evnt otkazan, tako da bi tribalo

@ninom5 ninom5 merged commit aa29c8c into main Oct 12, 2025
3 checks passed
@ninom5 ninom5 deleted the ninom5/delete-events-on-interview-slot-cancel branch October 12, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants