Skip to content

Sort answers by category and position #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ninom5 merged 2 commits into from
Oct 12, 2025
Merged

Sort answers by category and position #295

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d49984b
Sort answers by category and position
lucijs Oct 12, 2025
48ae7b2
handle undefined position
lucijs Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 46 additions & 28 deletions apps/web/src/components/InternInfo/InternInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@ import {
Intern,
InternDiscipline,
Question,
QuestionCategory,
TestStatus,
} from '@internship-app/types';
import { DataGrid, GridColDef } from '@mui/x-data-grid';
import moment from 'moment';

import { steps } from '../../constants/interviewConstants';
import styles from './index.module.css';

interface InternInfoProps {
Expand Down Expand Up @@ -132,34 +134,50 @@ export const InternInfo = ({ intern }: InternInfoProps) => {
</span>

{Array.isArray(intern.interviewSlot?.answers) &&
intern.interviewSlot?.answers.map((item: Answer) => {
if (!item.value) return null;

if (
!intern?.internDisciplines?.some(
(discipline) =>
discipline.discipline.toLowerCase() === 'marketing',
) &&
item.category === 'Marketing'
)
return null;

const formattedValue = Array.isArray(item.value)
? item.value.join(', ')
: item.value;

return (
<div
className={item.tick ? styles.tick : styles.atribute}
key={item.id}
>
<h3 className={styles.itemTitle}>
{item.question} {!item.tick || '⚠️'}
</h3>
<span>{formattedValue}</span>
</div>
);
})}
intern.interviewSlot?.answers
.sort((a: Answer, b: Answer) => {
const categoryCompare =
steps.findIndex(
(step: { category: QuestionCategory }) =>
step.category === a.category,
) -
steps.findIndex(
(step: { category: QuestionCategory }) =>
step.category === b.category,
);

if (categoryCompare !== 0) return categoryCompare;

return (a.position ?? 0) - (b.position ?? 0);
})
.map((item: Answer) => {
if (!item.value) return null;

if (
!intern?.internDisciplines?.some(
(discipline) =>
discipline.discipline.toLowerCase() === 'marketing',
) &&
item.category === 'Marketing'
)
return null;

const formattedValue = Array.isArray(item.value)
? item.value.join(', ')
: item.value;

return (
<div
className={item.tick ? styles.tick : styles.atribute}
key={item.id}
>
<h3 className={styles.itemTitle}>
{item.question} {!item.tick || '⚠️'}
</h3>
<span>{formattedValue}</span>
</div>
);
})}
</div>
)}
</div>
Expand Down