fix: Escape shell arguments for safety #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the security of shell command execution in
backend/dockerMailserver.jsby introducing proper escaping of user-supplied arguments. The most important changes include adding a utility function to escape shell arguments and updating all relevant command invocations to use this function, reducing the risk of shell injection vulnerabilities.Security improvements for shell command execution:
escapeShellArgfunction that safely escapes strings for use in shell commands by wrapping them in single quotes and escaping internal quotes.addAccount,updateAccountPassword, anddeleteAccountfunctions to useescapeShellArgfor email and password arguments when invoking shell commands. [1] [2] [3]addAliasanddeleteAliasfunctions to useescapeShellArgfor source and destination arguments in shell commands. [1] [2]