Ensure "Amount Off" discounts are applied once per cart#112
Merged
duncanmcclean merged 2 commits intomainfrom Jan 17, 2026
Merged
Ensure "Amount Off" discounts are applied once per cart#112duncanmcclean merged 2 commits intomainfrom
duncanmcclean merged 2 commits intomainfrom
Conversation
This test ensures that percentage discounts continue to be calculated correctly (each line item gets its percentage independently, which naturally sums to the correct total).
|
Released as part of v1.0.0-alpha.15. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request ensures that "Amount Off" discounts are applied once per cart, rather than applied per line item. Mirroring how LunarPHP handles fixed amount discounts.
Problem
The
AmountOff::calculate()method returned the full discount amount for every line item.For example: with a £1 discount and two different products, customers were receiving £2 off instead of £1 off.
Solution
This PR fixes it by distributing the fixed amount proportionally across all eligible line items based on their subtotals.
In this case, a £1 discount on a cart with two equal-value line items now gives £0.50 off each line item.