Skip to content

Tighten up email validation #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duncanmcclean merged 2 commits into from
Dec 4, 2025
Merged

Tighten up email validation #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33a50dd
Add failing test
duncanmcclean Dec 3, 2025
77c6d7b
Ensure email is valid according to PHP's filter_var
duncanmcclean Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Http/Requests/Cart/UpdateCartRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@ private function extraRules()
'customer.name' => ['nullable', 'string'],
'customer.first_name' => ['nullable', 'string'],
'customer.last_name' => ['nullable', 'string'],
'customer.email' => ['nullable', 'email'],
'customer.email' => ['nullable', 'email:filter'],
'name' => ['nullable', 'string'],
'first_name' => ['nullable', 'string'],
'last_name' => ['nullable', 'string'],
'email' => ['nullable', 'email'],
'email' => ['nullable', 'email:filter'],
'discount_code' => ['nullable', 'string', new ValidDiscountCode],
'shipping_method' => ['nullable', 'string'],
'shipping_option' => ['nullable', 'string'],
Expand Down
16 changes: 16 additions & 0 deletions tests/Cart/CartControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,22 @@ public function it_cant_add_invalid_discount_code()
$this->assertNull($cart->fresh()->get('discount_code'));
}

#[Test]
public function it_throws_validation_error_when_customer_email_is_invalid()
{
$cart = $this->makeCart();
$cart->customer(null)->save();

$this
->from('/cart')
->patch('/!/cargo/cart', [
'customer' => ['email' => 'name@domain'],
])
->assertSessionHasErrors('customer.email');

$this->assertNull($cart->fresh()->customer());
}

#[Test]
public function it_deletes_the_cart()
{
Expand Down