Deprecate from_env() #169
Merged
Deprecate from_env() #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| # Read from environment variables if not provided | ||
| api_key = api_key or os.environ["DUNE_API_KEY"] | ||
| base_url = base_url or os.environ.get("DUNE_API_BASE_URL", "https://api.dune.com") | ||
| request_timeout = request_timeout or float(os.environ.get("DUNE_API_REQUEST_TIMEOUT", "10")) |
There was a problem hiding this comment.
Bug: Constructor Fails to Respect Falsy Parameter Values
The BaseDuneClient constructor's use of the or operator for parameter fallback incorrectly overrides explicitly passed falsy values. This means api_key="", base_url="", or request_timeout=0.0 are ignored, falling back to environment variables or defaults instead of using the provided value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecated from_env() in favor of just using the DuneClient() constructor