Add TwoPhaseKnnVectorQuery #29
Conversation
dungba88
force-pushed
the
two-phase-vector
branch
from
dd8f079 to
96d2987
Compare
dungba88
force-pushed
the
two-phase-vector
branch
from
cf3e558 to
a06f980
Compare
dungba88
force-pushed
the
two-phase-vector
branch
from
a06f980 to
e2ab4bc
Compare
dungba88
force-pushed
the
two-phase-vector
branch
from
33c5fcd to
ccd3e25
Compare
| * | ||
| * @lucene.experimental | ||
| */ | ||
| public class TwoPhaseKnnVectorQuery extends KnnFloatVectorQuery { |
There was a problem hiding this comment.
I think we would need a brand new query that doesn't build on top of AbstractKnnVectorQuery. Instead, gets passed the desired knn query as a parameter & the desired target then the outer reranking query can call the knn query via rewrite.
There was a problem hiding this comment.
Oh that's a cleaner idea actually. Let me try it in next rev.
| for (int i = 0; i < NUM_VECTORS; i++) { | ||
| float[] vector = randomFloatVector(VECTOR_DIMENSION, random); | ||
| Document doc = new Document(); | ||
| doc.add(new IntField("id", i, Field.Store.YES)); | ||
| doc.add(new KnnFloatVectorField(FIELD, vector, VECTOR_SIMILARITY_FUNCTION)); | ||
| writer.addDocument(doc); | ||
| vectors.put(i, vector); | ||
| } |
There was a problem hiding this comment.
Maybe we should flush the writers a few time to create more than one segments, this make sure the code path that results are merged from multiple segments are executed.
There was a problem hiding this comment.
Good points, I added the flush() and uncovered/fixed a bug with doc ord.
dungba88
force-pushed
the
two-phase-vector
branch
from
d9f331f to
8cd3ccf
Compare
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you will stop receiving this reminder on future updates to the PR. |
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you will stop receiving this reminder on future updates to the PR. |
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you will stop receiving this reminder on future updates to the PR. |
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
Description
Draft for two-phase vector search (see apache#13564). Created a new Query for sake of simplicity.