feat: enable workers in dev (watchers) #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hello, just for my knowledge, how does this PR refers to #717 ? |
|
With these changes, shouldn't you remove the `--watch` argument from the
`CMD` line of the `frankenphp_dev` build traget ?
Then, without this argument, the `CMD` line would become the same than
`frankenphp_base` and you can even remove it from `frakenphp_dev`, isn't
it ?
|
dunglas
changed the title
|
|
|
@dunglas Just to be sure, we now activate worker mode regardless of the environment and enable the watcher only in dev ? |
|
Yes! |
|
Where run --watch command? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new "watcher" feature of FrankenPHP 1.4 to enable the worker mode in dev. Workers are automatically restarted when a file change.