Update Mercure configuration in Caddyfile #766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to dunglas/mercure#939 and the deprecation message, it makes sense to apply the edits to update the Mercure configuration. See https://github.com/dunglas/mercure/blob/main/docs/UPGRADE.md#017
|
It might be more correct to replace it with the new configuration format {$SERVER_NAME:localhost} {
# ...
mercure {
+ # Transport to use (default to Bolt)
+ transport bolt {
+ path /data/mercure.db
+ }However, this is already the default value. Backward compatibility (configuration via the environment variable |
dunglas
approved these changes
Mar 27, 2025
|
Simplifying the config is ok. |
|
I was too hasty with the default value. I found out that Mercure's default See https://github.com/dunglas/mercure/blob/6e73d7278ceb43c7cfd941089fe7bf984617a515/bolt.go#L88-L90 |
maxhelias
pushed a commit
that referenced
this pull request
Mar 27, 2025
This should return the path that was changed in #766.
gatiengnv
pushed a commit
to gatiengnv/stravinsight
that referenced
this pull request
Apr 14, 2025
This should return the path that was changed in dunglas/symfony-docker#766.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to dunglas/mercure#939 and the deprecation message, it makes sense to apply the Mercure configuration changes.
See: