fix: ensuring that containers can survive a docker upgrade when running using docker-compose#182
Merged
MasterKale merged 2 commits intoduo-labs:masterfrom Dec 16, 2025
Conversation
MasterKale
approved these changes
Dec 16, 2025
Collaborator
MasterKale
left a comment
MasterKale
left a comment
There was a problem hiding this comment.
Nice find @nickatduo, thank you for looking into the outage and figuring this out! This looks good to me 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docker restart policies allow for the restarting of Docker containers in a number of different scenarios, if the container fails, if the machine is rebooted etc.
While running this application, I've run into issues where we patch the underlying docker daemon, the containers are not started again. This is likely due to the fact that the patching process restarts the daemon, and this is considered a valid stop of the docker daemon. As we currently have
undless-stoppedconfigured, the containers aren't brought back up.So setting the restart policy to always to ensure that no matter what, they containers are started again, and we can stop having stochastic outages linked to the docker daemon updates.