Open
Conversation
d-rk
commented
Jan 24, 2022
| <Sidebar | ||
| visible={resultGroups.length > 0} | ||
| hiddenEngines={localData.hiddenEngines || []} | ||
| onToggle={engineId => { |
Contributor
Author
There was a problem hiding this comment.
the onToggle method here is the same like below in <Results. this needs to be refactored, but I gonna need help for this.
Member
|
Could you please post some screenshots? I'm having trouble getting the spinner to appear 🤔 Also I'd prefer to follow standard UI patterns (seen in other search websites like Google) by letting the user decide whether they want to open result links in new tabs (e.g. via middle click or ctrl+click) rather than deciding for them |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hi
I hope you don't mind another PR from me 😰
This PR introduces the following: