Open
Conversation
|
Lingo is https://lingoapp.com, not Duolingo |
Contributor
Author
|
@jwpjrdev thank you for the hint. I updated the logo |
Member
|
Wow! I'm curious, where did you get the images from? One reason why I hadn't done this being that I was never sure about committing to also providing images for all new engines going forward |
Contributor
Author
|
@artnc actually that was quite cumbersome 🙈 I first just added it for the services we are using internally. But for this PR I had to find all logos, which took some time. I mainly checked the brand/marketing pages of the companies for the logos. But for some of them I had to grab them elsewhere. I think going forward this shouldn't be a problem, because for a new engine that needs to be added only a single logo has to be found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
this is the final thing I modified and wanted to contribute back.
I added logos for all the engines: