Skip to content

Conversation

@jjfallete
Copy link

RotatingFileHandler is necessary to prevent the duologsync.log file from increasing in size indefinitely until the disk fills.

This allows for 3 rotations of the log file (4 total), each capping at 25MB.

We tested this and it appears to be working, but I recommend additional testing or adjusting of the added code as desired.

RotatingFileHandler is necessary to prevent the duologsync.log file from increasing in size indefinitely until the disk fills.

Requires testing prior to merge, I have not tested this.
@jjfallete jjfallete changed the title Update program.py Support for duologsync.log Rotation & Max File Size Mar 3, 2022
@Coldfirex
Copy link

Is this needed so we dont have to manually clear out the log file ever so often? It just grows in size.

@jjfallete
Copy link
Author

jjfallete commented Dec 15, 2023

@Coldfirex -- exactly. I'm not sure why Duo hasn't responded to this Pull Request. @MarkTripod-Duo maybe you can review?

It could be revised to be configurable within the ini as well, this was just a quick and dirty solution we've applied in our env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants