-
-
Notifications
You must be signed in to change notification settings - Fork 69
Build Python 3.14 wheels #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
db7a63c to
f298cfd
Compare
.github/workflows/packages.yml
Outdated
| env: | ||
| CIBW_BUILD: ${{matrix.pyver}}-* | ||
| CIBW_ENABLE: cpython-freethreading | ||
| CIBW_ENABLE: cpython-prerelease |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you moved this setting in the pyproject.toml file. Why is this setting defined here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's following advice from https://cibuildwheel.pypa.io/en/stable/options/#enable:
It is generally not recommended to use
cpython-prereleasein a config file, as it's intended for testing pre-releases for a 2-3 month period only.
No strong opinion from me either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...and that suggestion is gone in the latest docs so I guess it's OK to move this to pyproject.toml 😅
.github/workflows/packages.yml
Outdated
| env: | ||
| CIBW_BUILD: pp* | ||
| CIBW_SKIP: pp37-* | ||
| CIBW_ENABLE: pypy-eol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather drop support for EOL'd versions, contextually with the 3.14 release or earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.github/workflows/packages.yml
Outdated
|
|
||
| - name: Build wheels | ||
| uses: pypa/cibuildwheel@v2.23.3 | ||
| uses: pypa/cibuildwheel@v3.0.0rc2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should wait for the final version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, happy to wait for the final 3.0 release!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now using the final v3.0.0 release v3.1.0 release.
2ccdaf2 to
b6bd48c
Compare
|
@dvarrazzo this is g2g imo |
|
Thank you! I squashed your commits and trying a build on our side. If packages are all ok I'll merge. |
5504e30 to
04dd7db
Compare
|
Thanks! One of the builds seems to have got stuck: https://github.com/dvarrazzo/py-setproctitle/actions/runs/17476102842/job/49636232418 |
|
Yes, I got it unstucked and released 1.3.7 packages on PyPI. Thank you very much! |
The second beta was published a little over a week ago and the the first RC is coming out next month, so it's probably a good time to start building these 🙂
Successful "Package" job: https://github.com/edgarrmondragon/py-setproctitle/actions/runs/15587496141.