Fix for CPython 3.15 (clearenv) #158
Merged
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I have verified that the test introduced when #88 was fixed triggers this issue too, so we don't need a new test. Adding Python 3.15 to the test grid reveals the failure. |
Fix find_argv_from_env() if clearenv() has been called. Python 3.15 implements os.environ.clear() as clearenv(). Co-Authored-By: Karolina Surma <[email protected]>
dvarrazzo
force-pushed
the
fix_clearenv
branch
from
6c72eb7 to
68125ab
Compare
Owner
|
Added news entry, rebased on master, verified that tests pass on Py 3.15. Merging. Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix find_argv_from_env() if clearenv() has been called. Python 3.15 implements os.environ.clear() as clearenv().
Close #157