Skip to content

Offload blocking YAML dump to executor in sensor.py #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Moustachauve wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −5
Draft

Offload blocking YAML dump to executor in sensor.py #806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions custom_components/hilo/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,11 +778,10 @@ async def _load_history(self) -> list:
async def _save_history(self):
async with aiofiles.open(self._history_state_yaml, mode="w") as yaml_file:
LOG.debug("Saving history state to yaml file")
# TODO: Use asyncio.get_running_loop() and run_in_executor to write
# to the file in a non blocking manner. Currently, the file writes
# are properly async but the yaml dump is done synchroniously on the
# main event loop
await yaml_file.write(yaml.dump(self._history))
content = await asyncio.get_running_loop().run_in_executor(
None, yaml.dump, self._history
)
await yaml_file.write(content)


class HiloChallengeSensor(HiloEntity, SensorEntity):
Expand Down