Skip to content

Improve CI #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvonrohr merged 6 commits into from
Jun 11, 2020
Merged

Improve CI #5

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
691f15c
Support 8.x and 10.x versions of node only
dvonrohr Jun 11, 2020
8c31f49
Update .github/workflows/node.js.yml
dvonrohr Jun 11, 2020
d00e6e9
Use multiple jobs
dvonrohr Jun 11, 2020
cff28fa
Update .github/workflows/node.js.yml
dvonrohr Jun 11, 2020
e935f6e
fix: Indentation broken
dvonrohr Jun 11, 2020
ade5728
Update .github/workflows/node.js.yml
dvonrohr Jun 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ jobs:

strategy:
matrix:
node-version: [10.x, 12.x, 14.x]
os: [ubuntu-latest, windows-2016]
node-version: [8.x, 10.x]

steps:
- uses: actions/checkout@v2
Expand All @@ -27,3 +28,25 @@ jobs:
- run: npm ci
- run: npm run build --if-present
- run: npm test

- uses: actions/upload-artifact@master
with:
name: webpack artifacts
Copy link
Contributor

@github-learning-lab github-learning-lab bot Jun 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit this suggestion directly.

Suggested change
name: webpack artifacts
needs: build

path: public/
runs-on: ubuntu-latest
strategy:
matrix:
os: [ubuntu-latest, windows-2016]
node-version: [8.x, 10.x]
steps:
- uses: actions/checkout@2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@1
with:
node-version: ${{ matrix.node-version }}
- name: npm install, and test
run: |
npm install
npm test
env:
CI: true