Skip to content

Fix the offset issue in HtmlLayer when there are DOM elements outside the container that occupy height. #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the offset issue in HtmlLayer when there are DOM elements outside the container that occupy height. #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/modules/layer/type/HtmlLayer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import { Cesium } from '../../../libs'
import State from '../../state/State'
import { DomUtil } from '../../utils'
import { Util, DomUtil } from '../../utils'
import { Transform } from '../../transform'
import Layer from '../Layer'

Expand All @@ -13,6 +13,15 @@ class HtmlLayer extends Layer {
super(id)
this._delegate = DomUtil.create('div', 'html-layer', undefined)
this._delegate.setAttribute('id', this._id)
Util.merge(this._delegate.style, {
position: 'absolute',
left: '0',
top: '0',
width: '100%',
height: '100%',
pointerEvents: 'none',
})

this._renderRemoveCallback = undefined
this._state = State.INITIALIZED
}
Expand Down Expand Up @@ -45,7 +54,7 @@ class HtmlLayer extends Layer {
this._renderRemoveCallback = scene.postRender.addEventListener(() => {
let cp = this._viewer.camera.positionWC
let cd = this._viewer.camera.direction
const offset = this._viewer.getOffset()

this.eachOverlay((item) => {
if (item && item.position) {
let position = Transform.transformWGS84ToCartesian(item.position)
Expand All @@ -57,11 +66,6 @@ class HtmlLayer extends Layer {
scene,
position
)

if (windowCoord) {
windowCoord.x += offset.x
windowCoord.y += offset.y
}
item._updateStyle(
windowCoord,
Cesium.Cartesian3.distance(position, cp),
Expand Down
1 change: 1 addition & 0 deletions src/modules/overlay/html/DivIcon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ class DivIcon extends Overlay {
position: 'absolute',
top: '0',
left: '0',
pointerEvents: 'auto',
})
this.content = content
this._state = State.INITIALIZED
Expand Down