fix(visual): prevent redundant locking when caching solar configurations #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thep0y
commented
Oct 16, 2025
thep0y
commented
- Canonicalize theme directory path and log its absolute path
- Acquire cache lock once and reuse it for cache check and update
- Remove redundant nested locks to improve async lock handling
- Add clarifying comments around cache operations
- Maintain existing behavior of returning cached solar angles if available
- Canonicalize theme directory path and log its absolute path - Acquire cache lock once and reuse it for cache check and update - Remove redundant nested locks to improve async lock handling - Add clarifying comments around cache operations - Maintain existing behavior of returning cached solar angles if available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.