refactor(daemon): simplify initialization and move logging setup #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thep0y
commented
Oct 18, 2025
thep0y
commented
- Move logging setup to main function for early initialization
- Change DaemonApplication::new to synchronous constructor
- Remove async from ConfigManager::new and DaemonApplication::new methods
- Add Default implementation for DaemonApplication using new()
- Adjust ConfigManager constructor to support default config directory without async
- Clean up unnecessary imports and await usage in daemon code
- Move logging setup to main function for early initialization - Change DaemonApplication::new to synchronous constructor - Remove async from ConfigManager::new and DaemonApplication::new methods - Add Default implementation for DaemonApplication using new() - Adjust ConfigManager constructor to support default config directory without async - Clean up unnecessary imports and await usage in daemon code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.