Added NL formulation for Job-shop scheduling#20
Open
mhramani wants to merge 3 commits intodwave-examples:mainfrom
Open
Added NL formulation for Job-shop scheduling#20mhramani wants to merge 3 commits intodwave-examples:mainfrom
mhramani wants to merge 3 commits intodwave-examples:mainfrom
Conversation
mhramani
changed the title
hbarovertwo
reviewed
Jun 3, 2025
| from model_data import JobShopData | ||
| from utils.utils import print_cqm_stats | ||
|
|
||
| sys.path.append("./src") |
There was a problem hiding this comment.
We shouldn't have to manipulate the path, this indicates we are missing some structure in the directories (__init__.py isn't present in places it should be)
hbarovertwo
reviewed
Jun 3, 2025
| return self._job_tasks | ||
|
|
||
| @property | ||
| def job_resources(self) -> dict: |
There was a problem hiding this comment.
missing a docstring here as well as get_ordered_tasks
k8culver
requested changes
Jun 3, 2025
Collaborator
k8culver
left a comment
k8culver
left a comment
There was a problem hiding this comment.
This errors while trying to run it in the interface because callback functions run_optimization_cqm and run_optimization_mip are calling run_shop_scheduler with parameters you've removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.