Skip to content

update dependencies#65

Open
alexandraionel wants to merge 2 commits intomasterfrom
ale/dependencies-bump
Open

update dependencies#65
alexandraionel wants to merge 2 commits intomasterfrom
ale/dependencies-bump

Conversation

@alexandraionel
Copy link

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2026

⚠️ No Changeset found

Latest commit: 79f2fcf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

.name('honeydew')
.description('C# Analysis Tool')
.option('-wd --working-directory', 'Selects the directory where Honeydew will store the results folder.' +
.helpGroup('Analysis')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the help group?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cli-new checks if the plugin command has a .helpGroup() method to determine if it's compatible with Commander v14. If the method doesn't exist, the plugin is marked as "incompatible with this CLI version
(needs update)".

So .helpGroup('Analysis') serves two purposes:

  1. Passes the compatibility check in cli-new
  2. Groups the command under "Analysis" in the help output (which is the actual Commander v14 feature)

.description('C# Analysis Tool')
.option('-wd --working-directory', 'Selects the directory where Honeydew will store the results folder.' +
.helpGroup('Analysis')
.option('-w, --working-directory', 'Selects the directory where Honeydew will store the results folder.' +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not -wd?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commander v14 enforces stricter validation for option flags:

Short flags must be a single dash followed by a single character.

  • -w is valid (single dash + single char)
  • -wd is invalid (single dash + two chars)

package.json Outdated
"cli-progress": "^3.12.0",
"commander": "^11.1.0",
"commander": "^14.0.2",
"java-caller": "^4.3.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no java-caller needed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants