refactor(TokenBar): improve token display formatting#2783
refactor(TokenBar): improve token display formatting#2783wwwillchen merged 6 commits intodyad-sh:mainfrom
Conversation
|
@BugBot run |
Summary of ChangesHello @wwwillchen-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the user interface and experience of the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Greptile SummaryThis PR refactors the Key Changes:
Note: The PR description mentions adding a "centered separator dot" and Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 85b6666 |
🔍 Dyadbot Code Review SummaryVerdict: ⛔ NO - Do NOT merge Reviewed by 3 independent agents: Correctness Expert, Code Health Expert, UX Wizard. Issues Summary
🟢 Low Priority Notes (1 item)
🚫 Dropped False Positives (0 items)No false positives to report. Details🔴 HIGH: Text change breaks e2e test assertions The PR changes the displayed text from await expect(po.page.getByTestId("token-bar")).toContainText("6% of 128K");
await expect(po.page.getByTestId("token-bar")).toContainText("100% of 128K");These e2e tests will fail because the text content no longer contains "of". Fix: Update the e2e test assertions to match the new format, or keep the "of" text visible (e.g., visually hidden for screen readers). Generated by Dyadbot multi-agent code review |
|
@BugBot run |
Refactored the percentage and context window display to use a cleaner layout with flex alignment and a centered separator dot. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
ddee263 to
35c360a
Compare
|
@BugBot run |
- Update supabase_branch E2E snapshot to match new "Context window: YK" format instead of old "X% of YK" format Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The w-full TooltipTrigger causes the base-ui tooltip (delay=0) to appear instantly when the dropdown menu closes and the mouse lands on the trigger. Move mouse away before the second toggleTokenBar() to dismiss it. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
✅ Claude Code completed successfullySummary
Review Comments Addressed
CI Fixes
DetailsARIA Snapshot Fix: E2E Tooltip Fix: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95e3439f8b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@BugBot run |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85b66660c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🔍 Dyadbot Code Review SummaryVerdict: ✅ YES - Ready to merge Reviewed by 3 independent agents: Correctness Expert, Code Health Expert, UX Wizard. Issues Summary
🟢 Low Priority Notes (1 item)
🚫 Dropped False Positives (4 items)
Generated by Dyadbot multi-agent code review |
🎭 Playwright Test Results❌ Some tests failed
Summary: 232 passed, 3 failed, 5 flaky, 6 skipped Failed Tests🍎 macOS
📋 Re-run Failing Tests (macOS)Copy and paste to re-run all failing spec files locally: npm run e2e \
e2e-tests/rebuild.spec.ts \
e2e-tests/select_component.spec.ts \
e2e-tests/template-create-nextjs.spec.ts
|
✅ Claude Code completed successfullySummary
DetailsReview Comments Addressed
CI Check Analysis
|
🤖 Claude Code Review SummaryPR Confidence: 4/5All review comments addressed and resolved; the only remaining risk is pre-existing flaky E2E tests unrelated to this PR. Unresolved ThreadsNo unresolved threads Resolved Threads
Product Principle SuggestionsNo suggestions — principles were clear enough for all decisions. 🤖 Generated by Claude Code |
Summary
items-centerand consistent spacingTest plan
🤖 Generated with Claude Code