fix: Rechecktx idling when mempool is empty #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
northstar456
reviewed
Dec 8, 2025
| } | ||
| } | ||
|
|
||
| if mem.Size() <= 0 { |
Collaborator
There was a problem hiding this comment.
Nit: could you add a quick comment on why it's important to early return here when mem.Size() is 0/
northstar456
approved these changes
Dec 8, 2025
pthmas
force-pushed
the
pierrick/fix-recheck-idle
branch
from
c755a1c to
a2cf77d
Compare
teddyding
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where, when a block had only Short Term Clob Order Transactions these would be remove form the mempool but
recheckTxswould try to recheck an empty mempool, but still wait for the channel signal that all the transactions are processed. This would cause the node to idle until therecheck_timeoutduration was over. Over time, this would cause the node to fall behind consensus consistently for sometimes hours at a time. The small changes in this PR implement a check after the Short Term Clob Order Transactions to verify if there are still other transactions in the mempool to run RecheckTx on.