[ENG-1623] Do not return error when pnl/parentSubaccountNumber returns empty array (backport #3291)#3292
Merged
davidli1997 merged 1 commit intorelease/indexer/v9.xfrom Dec 19, 2025
Conversation
6 tasks
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
jusbar23
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelist
Fix
/v4/pnl/parentSubaccountNumberendpoint to return empty array instead of error when no PNL data matches filterspnlData.results.length === 0- now returns{"pnl":[]}instead of an errorTest Plan
Added controller tests:
Get /pnl/parentSubaccountNumber returns empty array when date filter excludes all data- verifies both daily and hourly endpoints return 200 with empty array when createdBeforeOrAt excludes all recordsGet /pnl/parentSubaccountNumber returns empty array when no PNL records exist- verifies empty array is returned when subaccount exists but has no PNL dataUpdated Get /pnl/parentSubaccountNumber with non-existent address returns 404- verifies 404 is still returned for non-existent addressesTested in staging,


before:
after:
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.This is an automatic backport of pull request #3291 done by [Mergify](https://mergify.com).