feat: Add Authenticator flow for Permissioned Keys#317
Merged
adamfraser merged 7 commits intomainfrom Jan 29, 2025
Merged
Conversation
jayy04
previously approved these changes
Jan 27, 2025
ruixhuang
previously approved these changes
Jan 27, 2025
adamfraser
force-pushed
the
adam/add-authentications-functions
branch
from
d050d77 to
e0d1c76
Compare
adamfraser
changed the title
adamfraser
force-pushed
the
adam/add-authentications-functions
branch
from
834cce5 to
ca2c897
Compare
adamfraser
changed the title
tyleroooo
approved these changes
Jan 28, 2025
kzdydx
reviewed
Jan 29, 2025
| const wallet1 = await LocalWallet.fromMnemonic(DYDX_TEST_MNEMONIC, BECH32_PREFIX); | ||
| const wallet2 = await LocalWallet.fromMnemonic(DYDX_TEST_MNEMONIC_2, BECH32_PREFIX); | ||
|
|
||
| const network = Network.staging(); |
Contributor
There was a problem hiding this comment.
Can this be set to testnet?
| // Change second wallet pubkey | ||
| // Add an authenticator to allow wallet2 to place orders | ||
| console.log("** Adding authenticator **"); | ||
| await addAuthenticator(client, subaccount1, wallet2.pubKey!.value); |
Contributor
There was a problem hiding this comment.
Could you add some delay here, as it seems it goes to fast between adding and doing the getAuthenticators step after that
await sleep(500);
|
Thanks @adamfraser for this PR. Any word on when authenticators for long term (stateful) orders will be supported in Typescript? (#319) |
tyleroooo
added a commit
that referenced
this pull request
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functionality to enable signing transactions using the authenticator flow on the protocol.