feat: Add Authenticator flow for Permissioned Keys#330
Merged
UnbornAztecKing merged 4 commits intodydxprotocol:mainfrom Mar 4, 2025
Merged
feat: Add Authenticator flow for Permissioned Keys#330UnbornAztecKing merged 4 commits intodydxprotocol:mainfrom
UnbornAztecKing merged 4 commits intodydxprotocol:mainfrom
Conversation
I only fixed and cleaned previous PR dydxprotocol#328 by konichuvak Author: pnowosie <pawel@nethermind.io>, konichuvak <konichuvak@proton.me>
pnowosie
force-pushed
the
pnowosie/permissioned-keys-python
branch
from
97aaf6c to
fbc6502
Compare
UnbornAztecKing
requested changes
Feb 26, 2025
Contributor
UnbornAztecKing
left a comment
UnbornAztecKing
left a comment
There was a problem hiding this comment.
Only a few methods have return type annotations.
I'd prefer they do to improve the experience for users that are type checking.
A couple of other nits, but looks good overall!
UnbornAztecKing
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is cleaned & fixed version of #328
Big thanks to the original contributor: @konichuvak