Skip to content

feat: Add TWAP types for v4-client-js #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dankim214 merged 2 commits into from
Feb 20, 2026
Merged

feat: Add TWAP types for v4-client-js #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f168bee
add types
dankim214 Feb 20, 2026
7394ee1
run webpack
dankim214 Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions v4-client-js/__native__/__ios__/v4-native-client.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions v4-client-js/src/clients/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,8 @@ export enum OrderType {
TAKE_PROFIT_LIMIT = 'TAKE_PROFIT',
STOP_MARKET = 'STOP_MARKET',
TAKE_PROFIT_MARKET = 'TAKE_PROFIT_MARKET',
TWAP = 'TWAP',
TWAP_SUBORDER = 'TWAP_SUBORDER',
}

// ------------ Order Side ------------
Expand Down
10 changes: 10 additions & 0 deletions v4-client-js/src/clients/helpers/chain-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,10 @@ export function calculateTimeInForce(
throw new Error('Unexpected code path: timeInForce');
}

case OrderType.TWAP:
case OrderType.TWAP_SUBORDER:
return Order_TimeInForce.TIME_IN_FORCE_UNSPECIFIED;

default:
throw new Error('Unexpected code path: timeInForce');
}
Expand All @@ -159,6 +163,12 @@ export function calculateOrderFlags(type: OrderType, timeInForce?: OrderTimeInFo
case OrderType.TAKE_PROFIT_MARKET:
return OrderFlags.CONDITIONAL;

case OrderType.TWAP:
return OrderFlags.TWAP;

case OrderType.TWAP_SUBORDER:
return OrderFlags.TWAP_SUBORDER;

default:
throw new Error('Unexpected code path: orderFlags');
}
Expand Down
2 changes: 2 additions & 0 deletions v4-client-js/src/clients/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ export enum OrderFlags {
SHORT_TERM = 0,
LONG_TERM = 64,
CONDITIONAL = 32,
TWAP = 128,
TWAP_SUBORDER = 256,
}

// TWAP order parameters
Expand Down
6 changes: 4 additions & 2 deletions v4-client-js/src/lib/validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,12 +173,14 @@ export function verifyOrderFlags(orderFlags: OrderFlags): boolean {
return (
orderFlags === OrderFlags.SHORT_TERM ||
orderFlags === OrderFlags.LONG_TERM ||
orderFlags === OrderFlags.CONDITIONAL
orderFlags === OrderFlags.CONDITIONAL ||
orderFlags === OrderFlags.TWAP ||
orderFlags === OrderFlags.TWAP_SUBORDER
);
}

export function isStatefulOrder(orderFlags: OrderFlags): boolean {
return orderFlags === OrderFlags.LONG_TERM || orderFlags === OrderFlags.CONDITIONAL;
return orderFlags === OrderFlags.LONG_TERM || orderFlags === OrderFlags.CONDITIONAL || orderFlags === OrderFlags.TWAP || orderFlags === OrderFlags.TWAP_SUBORDER;
}

function verifyIsBech32(address: string): Error | undefined {
Expand Down
Loading