-
Notifications
You must be signed in to change notification settings - Fork 45
Add revshare and update docs feedback #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive documentation for the new revenue share feature and provides documentation improvements based on user feedback.
Key changes include:
- Addition of complete revenue share documentation covering governance voting, implementation details, and order message updates
- Enhancement of trading documentation with recommendations for using specific client IDs when placing orders
- Improvements to onboarding documentation with better explanations of address generation and subaccount structure
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| integration-revshare.mdx | New comprehensive documentation for the Order Router Revenue Share feature |
| trading/index.mdx | Added recommendation to use specific client IDs for order tracking |
| integration-onboarding.mdx | Enhanced onboarding docs with detailed address generation and subaccount explanations |
| market.mdx | Added client ID recommendation for order retrieval |
| isolated-positions.md | Improved formatting and added clarifications about subaccount behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
vocs-docs/docs/pages/interaction/integration/integration-revshare.mdx
Outdated
Show resolved
Hide resolved
vocs-docs/docs/pages/interaction/integration/integration-onboarding.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
No description provided.