Deprecate WalletConnect and update to Reown #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruixhuang
commented
Oct 27, 2025
| excludedWalletIds: [ | ||
| ] | ||
| ], | ||
| coinbaseEnabled: false // we manage Coinbase ourselves |
Collaborator
Author
There was a problem hiding this comment.
cc @Sam-dYdX It could be worthwhile to migrate our Coinbase wallet integration to Reown as well at some point.
Sam-dYdX
approved these changes
Oct 27, 2025
Sam-dYdX
reviewed
Oct 27, 2025
| if success { | ||
| self?.reallySign(typedDataProvider: typedDataProvider, | ||
| accountAddress: request.address, | ||
| chainId: request.chainId) { [weak self] signed, error in |
Contributor
There was a problem hiding this comment.
Just curious what was the reason to remove the [weak self]? Is it because we want this to run even if there isn't a reference to self anymore?
Collaborator
Author
There was a problem hiding this comment.
The block doesn't reference to self, so no need to do weak self to avoid retain cycle.
jaredvu
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple now complains about the privacy declaration with the WalletConnect framework, so let's land this ahead of schedule.