fix: reward amount (#1931)

Author: tyleroooo

package.json

@@ -55,7 +55,7 @@
     "@cosmjs/tendermint-rpc": "^0.32.1",
     "@datadog/browser-logs": "^5.23.3",
     "@dydxprotocol/v4-client-js": "3.0.3",
-    "@dydxprotocol/v4-localization": "1.1.332",
+    "@dydxprotocol/v4-localization": "1.1.333",
     "@dydxprotocol/v4-proto": "^7.0.0-dev.0",
     "@emotion/is-prop-valid": "^1.3.0",
     "@hugocxl/react-to-image": "^0.0.9",

pnpm-lock.yaml

@@ -13,6 +13,8 @@ import { MAX_SUBACCOUNT_NUMBER, NUM_PARENT_SUBACCOUNTS } from '@/constants/accou
 import { MAJOR_MARKETS } from '@/constants/markets';
 import { IndexerPositionSide } from '@/types/indexer/indexerApiGen';
 
+import { OCT_2025_REWARDS_DETAILS } from '@/hooks/rewards/util';
+
 import { assertNever } from '@/lib/assertNever';
 import { calc, mapIfPresent } from '@/lib/do';
 import {
@@ -888,14 +890,22 @@ function divideIfNonZeroElse(numerator: number, denominator: number, backup: num
 const RATE_LOST_TO_REV_SHARES = 0.4; // megavault and ops
 const MAX_POSSIBLE_TAKER_REV_SHARE = 0.5; // affiliates
 
+const IS_FEE_REBATE_TIME: boolean = true;
+const FEE_REBATE_PERCENT = OCT_2025_REWARDS_DETAILS.rebateFraction;
+
 function calculateTakerReward(
   usdcSize: number | undefined,
   fee: number | undefined,
   rewardsParams: RewardParamsSummary | undefined,
   feeTiers: FeeTierSummary[] | undefined
 ): number | undefined {
-  const feeMultiplier = rewardsParams?.feeMultiplier;
   const tokenPrice = rewardsParams?.tokenPrice;
+  if (IS_FEE_REBATE_TIME) {
+    return fee != null && tokenPrice != null && tokenPrice > 0
+      ? (fee * FEE_REBATE_PERCENT) / tokenPrice
+      : undefined;
+  }
+  const feeMultiplier = rewardsParams?.feeMultiplier;
   const notional = usdcSize;
   const maxMakerRebate = findMaxMakerRebate(feeTiers);
 
@@ -921,8 +931,13 @@ function calculateMakerReward(
   fee: number | undefined,
   rewardsParams: RewardParamsSummary | undefined
 ): number | undefined {
-  const feeMultiplier = rewardsParams?.feeMultiplier;
   const tokenPrice = rewardsParams?.tokenPrice;
+  if (IS_FEE_REBATE_TIME) {
+    return fee != null && tokenPrice != null && tokenPrice > 0
+      ? (fee * FEE_REBATE_PERCENT) / tokenPrice
+      : undefined;
+  }
+  const feeMultiplier = rewardsParams?.feeMultiplier;
 
   if (fee != null && feeMultiplier != null && tokenPrice != null && fee > 0.0 && tokenPrice > 0.0) {
     return (fee * feeMultiplier * RATE_LOST_TO_REV_SHARES) / tokenPrice;

src/bonsai/forms/trade/tradeInfo.ts

@@ -1,5 +1,7 @@
 import { TOOLTIP_STRING_KEYS, type TooltipStrings } from '@/constants/localization';
 
+import { OCT_2025_REWARDS_DETAILS } from '@/hooks/rewards/util';
+
 export const tradeTooltips = {
   'account-leverage': ({ stringGetter }) => ({
     title: stringGetter({ key: TOOLTIP_STRING_KEYS.ACCOUNT_LEVERAGE_TITLE }),
@@ -141,7 +143,13 @@ export const tradeTooltips = {
   }),
   'max-reward-sept-2025': ({ stringGetter }) => ({
     title: stringGetter({ key: TOOLTIP_STRING_KEYS.MAXIMUM_REWARDS_SEPT_2025_TITLE }),
-    body: stringGetter({ key: TOOLTIP_STRING_KEYS.MAXIMUM_REWARDS_SEPT_2025_BODY }),
+    body: stringGetter({
+      key: TOOLTIP_STRING_KEYS.MAXIMUM_REWARDS_SEPT_2025_BODY,
+      params: {
+        REWARD_PERCENT: OCT_2025_REWARDS_DETAILS.rebatePercentNumeric,
+        REWARD_AMOUNT: OCT_2025_REWARDS_DETAILS.rewardAmount,
+      },
+    }),
   }),
   'max-withdraw': ({ stringGetter }) => ({
     title: stringGetter({ key: TOOLTIP_STRING_KEYS.MAX_WITHDRAW_TITLE }),

src/constants/tooltips/trade.ts

@@ -24,5 +24,7 @@ export const OCT_2025_REWARDS_DETAILS = {
   rewardAmount: '$1M',
   rewardAmountUsd: 1_000_000,
   rebatePercent: '100%',
+  rebatePercentNumeric: '100',
+  rebateFraction: 1,
   endTime: '2025-10-31T23:59:59.000Z', // end of month
 };